Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix tests to work with recent elastic-apm-node that includes a log preamble #148

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

trentm
Copy link
Member

@trentm trentm commented Oct 3, 2023

Since [email protected] the APM agent will log.info a preamble with config and some other basic debugging info. This was breaking the APM-related tests.

… log preamble

Since [email protected] the APM agent will log.info a
preamble with config and some other basic debugging info.
This was breaking the APM-related tests.
@trentm trentm self-assigned this Oct 3, 2023
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Oct 3, 2023
@trentm trentm requested a review from david-luna October 3, 2023 23:13
Copy link
Member

@david-luna david-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elasticmachine, run elasticsearch-ci/docs

@david-luna
Copy link
Member

@elasticmachine, run elasticsearch-ci/docs

1 similar comment
@v1v
Copy link
Member

v1v commented Oct 4, 2023

@elasticmachine, run elasticsearch-ci/docs

@david-luna david-luna merged commit 2a6ea19 into main Oct 4, 2023
7 checks passed
@david-luna david-luna deleted the trentm/fix-tests-preamble branch October 4, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants