-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
actions: use go-version-file: .go-version #558
Merged
oren-zohar
merged 1 commit into
elastic:main
from
v1v:feature/simplify-go-version-github-actions
Nov 30, 2022
Merged
actions: use go-version-file: .go-version #558
oren-zohar
merged 1 commit into
elastic:main
from
v1v:feature/simplify-go-version-github-actions
Nov 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request does not have a backport label. Could you fix it @v1v? 🙏
|
oren-zohar
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
v1v
added
backport-v8.5.0
backport pr to 8.5 branch
backport-v8.6.0
and removed
backport-skip
labels
Nov 30, 2022
Cloudbeat CI 🤖Allure Report: http://csp-allure-reports.s3.amazonaws.com/allure_reports/cloudbeat/prs/558/index.html |
mergify bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
(cherry picked from commit b2234cc)
mergify bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
(cherry picked from commit b2234cc)
oren-zohar
pushed a commit
that referenced
this pull request
Nov 30, 2022
actions: use go-version-file: .go-version (#558) (cherry picked from commit b2234cc) Co-authored-by: Victor Martinez <[email protected]>
oren-zohar
pushed a commit
that referenced
this pull request
Nov 30, 2022
actions: use go-version-file: .go-version (#558) (cherry picked from commit b2234cc) Co-authored-by: Victor Martinez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use the
setup-go
action with thego-version-file
input so it reads the file.go-version
Why is it important?
Avoid the logic to read and create env variables and use the undocumented
.go-version-file
See actions/setup-go#295