Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding utility to mock environment variables #2195

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Oct 18, 2021

Adding a utility to test scenarios with custom env variables.
Originally implemented for removal of system-lambda (as part of #2184), but I want to use it in a current PR I am doing now.

@eyalkoren eyalkoren requested a review from SylvainJuge October 18, 2021 07:20
@eyalkoren eyalkoren removed the request for review from SylvainJuge October 18, 2021 07:23
@apmmachine
Copy link
Contributor

apmmachine commented Oct 18, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-18T08:29:14.478+0000

  • Duration: 59 min 45 sec

  • Commit: cee4bf3

Test stats 🧪

Test Results
Failed 0
Passed 2427
Skipped 19
Total 2446

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run compatibility tests : Run the JDK Compatibility test.

  • run integration tests : Run the APM-ITs.

@AlexanderWert AlexanderWert added this to the 7.16 milestone Oct 18, 2021
@eyalkoren
Copy link
Contributor Author

closes #1942

@eyalkoren eyalkoren merged commit 1780251 into elastic:master Oct 18, 2021
@eyalkoren eyalkoren deleted the env-variable-testing branch October 18, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants