-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gs][experience.rb] add rpa? and lumnis? API calls #483
Draft
mrhoribu
wants to merge
22
commits into
elanthia-online:staging
Choose a base branch
from
mrhoribu:experience-additions
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add percent_fxp percent_axp percent_exp lumnis? rpa?
Add `[You currently have a role playing award active, and cannot activate another until your current one has expired.]` to the parser
mrhoribu
added a commit
that referenced
this pull request
Dec 1, 2023
Add experience percent options (separating from PR #483 to allow for merging methods sooner
mrhoribu
changed the title
[experience.rb] add rpa?, lumnis? and percent API calls
[experience.rb] add rpa? and lumnis? API calls
Dec 1, 2023
remove percent experience methods as moved to PR 515
merge staging into branch
mrhoribu
changed the title
[experience.rb] add rpa? and lumnis? API calls
[gs4][experience.rb] add rpa? and lumnis? API calls
Apr 25, 2024
Time to update this and bring it forward to 5.10? Only thing that might still be debatable is when to turn off Experience.rpa? And one trigger could easily be when you don't have the appropriate line in the EXP output. |
mrhoribu
changed the title
[gs4][experience.rb] add rpa? and lumnis? API calls
[gs][experience.rb] add rpa? and lumnis? API calls
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the tracking of RPA and Lumnis to infomon and retrievable via
Experience.rpa?
andExperience.lumnis?
. Resolves part of #449 issue