Updates to sigilharvest and common-items to fix some logic errors in the former and add compatibility to the latter #6721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new match pattern to match_messages in count_item_parts() method
This was previously buggy and failing to order scrolls much of the time. I redid some of the logic and moved to ROUND instead of CEIL which will reduce over-buying of scrolls.
Space after # in some comments added Removed redundant .to_s methods
added missing space after # for one of my comments
|
Thank you Rubocop for making my code less of a nightmare. :) All the issues should now be fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common-items: added another match string to make count_item_parts compatible with blank scrolls.
sigilharvest: fixed some logic errors that were preventing the script from buying scrolls when it otherwise should have been
NOTE: The changes to sigilharvest are dependent upon the match string added to common-items.