Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove highlight when clicking external studio link #925

Merged

Conversation

owi92
Copy link
Member

@owi92 owi92 commented Aug 25, 2023

The "Record video" link kept being highlighted after it was clicked, meaning more than one nav item was highlighted at once (since the active route always is). This fixes the issue.

@github-actions github-actions bot temporarily deployed to test-deployment-pr925 August 25, 2023 10:51 Destroyed
@owi92 owi92 added the changelog:user User facing changes label Sep 1, 2023
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I am not yet merging as we currently have problems with CI not running.

The record video link kept being highlighted after it was clicked,
meaning more than one nav item was highlighted since the active route
always is. This fixes the issue.
@owi92 owi92 force-pushed the remove-external-link-highlight branch from 69ee024 to d12582d Compare September 11, 2023 12:23
@LukasKalbertodt LukasKalbertodt merged commit 926d7ed into elan-ev:master Sep 11, 2023
2 checks passed
@owi92 owi92 deleted the remove-external-link-highlight branch March 4, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:user User facing changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants