Split "manage single video" page into multiple pages #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
status:conflicts
This comment was marked as resolved.
This comment was marked as resolved.
LukasKalbertodt
force-pushed
the
make-manage-video-multi-page
branch
from
ee03241 to
8d9f2f8
Compare
github-actions
bot
removed
the
status:conflicts
This was only used in one place where it was configured like that anyway. We might want to improve the style of this in the future still.
We will still add a lot more stuff and we can't possibly cram it all on one page. This is similar to how YouTube does it, for example. Currently, there are only 2 sub pages, but there are already commented out entries for two more. Most notably, this commit: - Moves the "technical details" part to a new sub page - Some new technical details are shown - Adds a nav element to switch between different sub pages - Said nav element also contains the thumbnail and title of the video - As such, the thumbnail on the actual manage page is removed and the updated/created timestamps are moved elsewhere on the page.
Our reasoning is: those are easily accessible to everyone anyway, none of that is "secret". So linking them here directly doesn't change anything. But further, only users who can edit this video can see those, so it's extra fine.
Before, it returned "" as path for the root realm, which is different from what the normal API does.
LukasKalbertodt
force-pushed
the
make-manage-video-multi-page
branch
from
8d9f2f8 to
06d59f3
Compare
JulianKniephoff
requested changes
Dec 9, 2022
JulianKniephoff
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it more extensible in the future. We certainly want to add another sub page for ACLs/managing access (see #356). The previous single page was already filled with lots of stuff and putting the technical info on its own page helps with clarity.
See all commit messages for more detail.
Some notes and ideas on potential sub pages