Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group edit series options #1079

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

geichelberger
Copy link
Contributor

As discussed in PR #1021 this is a PoC to test screenreader output with individual groups.

As discussed in PR elan-ev#1021 this is a
PoC to test screenreader output with individual groups.
@geichelberger
Copy link
Contributor Author

@owi92 Fedoras screen reader ignores the headings in the current master branch version. That may not be the case for VoiceOver. Grouping the options individually works for me.

Copy link
Member

@owi92 owi92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VoiceOver now reads the headings twice (or it rather reads the aria-label first and then the heading) but that's ok I think. We do want this to work for all users.
Thank you for testing and implementing this!

@owi92 owi92 merged commit 3ec29ec into elan-ev:master Jan 16, 2024
2 checks passed
@owi92 owi92 added area:accessibility Accessibility related issues changelog:user User facing changes labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:accessibility Accessibility related issues changelog:user User facing changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants