Rename view to layout and adjust spacing
#1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We just noticed that "view" might not be the best name. Previously it wasn't that important but now that it was mentioned in a soon to be immutable DB migration, we wanted to fix it. This commit is just renaming, and not doing anything else.
I think it looks better with a bit more breathing room.
|
Same as with the original PR by Gregor: we can ignore the failing admin UI check. |
|
The last options are already called layout shouldn't they be renamed as well?
|
|
Good catch, yep the label should be renamed. Will do |
|
Whoops, only looked at the german version just now. Time for a coffee 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits. In terms of review, the first commit doesn't need to be code-reviewed at all. I think basically all bugs I could introduce there are caught by type checking.