Fix router bug accessing null history.state
#1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lead to a critical error in situation where Tobira redirected internally after a login. We accidentally replaced the state by `null`, which was later accessed. Both of these change-snippets solve the bug, but both are useful. The redirect forward shouldn't just set the state to null, and the router should never assume the state is non-null.
LukasKalbertodt
changed the title
null history.state`null history.state
owi92
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lead to a critical error in situation where Tobira redirected internally after a login. We accidentally replaced the state by
null, which was later accessed. Both of these change-snippets solve the bug, but both are useful. The redirect forward shouldn't just set the state to null, and the router should never assume the state is non-null.This was found by @KatrinIhler when deploying for Bern.