Add arrow navigation to remaining popover menus #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owi92
force-pushed
the
sorting-menu-arrow-nav
branch
from
d4d46d5 to
b5b954b
Compare
owi92
changed the title
owi92
force-pushed
the
sorting-menu-arrow-nav
branch
from
566bca3 to
1963003
Compare
- refactor `add button` menu component, giving it access to `floating` context - deduplicate some code
owi92
force-pushed
the
sorting-menu-arrow-nav
branch
3 times, most recently
from
e8f5350 to
bc3739d
Compare
LukasKalbertodt
requested changes
Jan 15, 2024
There was a problem hiding this comment.
The view/order buttons of series blocks currently don't do anything when clicked or otherwise activated. I suppose the onClick handler just needs to be specified after the getItemProps or whatever.
Other than that it looks good to me. I only skimmed the refactor parts, but should be fine.
owi92
force-pushed
the
sorting-menu-arrow-nav
branch
from
bc3739d to
ad1f0ed
Compare
Good catch, that fixes it. |
LukasKalbertodt
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables arrow navigation for the series block sorting menus and the menus for adding block content.
Waiting for opencast/appkit#3, which is needed in order for this to work.
Together they will close #753.