Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change manifold_calculate_normals min_sharp_angle type to double #1085

Merged

Conversation

NickUfer
Copy link
Contributor

@NickUfer NickUfer commented Dec 1, 2024

Fixes #1083

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.72%. Comparing base (2162d8d) to head (4a91fbe).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1085   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files          30       30           
  Lines        5910     5910           
=======================================
  Hits         5421     5421           
  Misses        489      489           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pca006132 pca006132 merged commit 8556840 into elalish:master Dec 1, 2024
25 checks passed
@pca006132
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C binding function manifold_calculate_normals contains parameter type mistmatch
2 participants