-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasm-tbb: increase stack size and add CI #1079
Conversation
Emscripten may soon fix the vite issue: emscripten-core/emscripten#22394 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1079 +/- ##
=======================================
Coverage 91.72% 91.72%
=======================================
Files 30 30
Lines 5910 5910
=======================================
Hits 5421 5421
Misses 489 489 ☔ View full report in Codecov by Sentry. |
hmmm, the vite thing is annoying, I guess it is due to emscripten version issue... |
And it seems that emscripten pthread support is not that stable for 3.1.64 ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, is this one ready? Should I update our branch rules so we can merge it?
Is this PR intended to fix this problem? https://github.com/elalish/manifold/actions/runs/12076790849/job/33678681856 |
Branch rule: Yes, the name should be stable. I am not entirely sure if I want to experiment with newer versions of emscripten or not. iirc newer version runs fine in the CI (with only a few runs though, not sure if it is a lot more stable than what we have now), but because nixos haven't yet support the newer versions of emscripten, I will need to use it inside a container to figure out how to patch the js file to make vite happy. Currently, I simply avoid running the tests on the CI, and just treat this as a compilation test, because we know that it is unstable for the emscripten version we have tested. |
Hmmm, for some reason vite did not complain about workerOptions issue with emscripten 3.1.73 when run inside a docker, idk what happened. I think we can merge this for now. |
But apparently 3.1.73 works fine without issue, at least on my machine. 3.1.61/64 will sometimes produce the issue. |
May break when I add some assertions, very non-deterministic. And sadly emscripten does not support address sanitizer on wasm workers for now... |
Added warnings to the readme for enabling parallelization with emscripten, as well as changed the emscripten |
Now run in "normal" CI as well with npm test.
Also updates dependency versions.