-
Notifications
You must be signed in to change notification settings - Fork 210
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
- Loading branch information
Showing
1 changed file
with
9 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b53f399
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest
'nodeenv/' + nodeenv_version + ' (https://github.com/ekalinin/nodeenv/)'
which would match convension for user agent strings[1]. While the link below is for automated agents, the convention is typical for utilities and scripts to provide a generic name/version with a url for the utility in the parameters section.[1] https://en.wikipedia.org/wiki/User_agent#Format_for_automated_agents_.28bots.29
b53f399
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you're right. Will fix it. Thanks.
b53f399
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 0.13.5