Fix version discovery; #356, #357 (#358)

ekalinin · Jun 4, 2024 · 69e310a · 69e310a
1 parent 9d74cd8
commit 69e310a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/nodeenv.py b/nodeenv.py
@@ -175,7 +175,11 @@ def parse_version(version_str):
     """
     Parse version string to a tuple of integer parts
     """
-    return tuple(map(int, version_str.replace('v', '').split('.')))
+    v = version_str.replace('v', '').split('.')[:3]
+    # remove all after '+' in the PATCH part of the version
+    if len(v) >= 3:
+        v[2] = v[2].split('+')[0]
+    return tuple(map(int, v))
 
 
 def node_version_from_args(args):

diff --git a/tests/nodeenv_test.py b/tests/nodeenv_test.py
@@ -161,3 +161,9 @@ def test__download_node_file():
                 n_attempt=5
             )
         assert m_urlopen.call_count == 5
+
+
+def test_parse_version():
+    assert nodeenv.parse_version("v21.7") == (21, 7)
+    assert nodeenv.parse_version("v21.7.3") == (21, 7, 3)
+    assert nodeenv.parse_version("v21.7.3+0-b20240228T18452699") == (21, 7, 3)