Make non-empty basepath work #1263
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The JoexServer is not affected by this, it is only used internally and not exposed, so I would simply skip this - Sadly, the javascript file has to be fixed as well that creates a websocket connection. Can be fixed by making it a template or passing the contextPath as argument - Need to fix the cookie path (I didn't make sure to fix all) - Another problem is obtaining the base url. Currently, if the config is set to "localhost" we simply clobber the url together from the request and here we don't know the base path and simply set the empty path. I now fixed this also to be "/andy", but we need to get the configured basePath from the config - Most changes in Elm was fixing the URL to preview images and files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix #1193