Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Force copy steering file to avoid error #9

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Force copy steering file to avoid error #9

merged 4 commits into from
Oct 30, 2023

Conversation

rahmans1
Copy link
Contributor

Right now it tries to copy even if the input steering file already exists locally. This is throwing errors in CI during timing calculations.

drwxr-xr-x 2 root root 4096 Oct 30 01:36 .
drwxrwxrwt 1 root root 4096 Oct 30 01:36 ..
Run: [ERROR] Local error: file exists:  (destination)
/opt/campaigns/single/scripts/run.sh: Error on line 111: xrdcp ${XRDURL}/${INPUT_FILE} ${INPUT_DIR}
SINGLE/mu-/10GeV/etaScan/mu-_10GeV_eta-1.7,steer,1000000,113.731454676,.11384
$ sort -o results/datasets/timings/$DATA results/datasets/timings/$DATA

Briefly, what does this PR introduce?

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

Right now it tries to copy even if the input steering file already exists locally. This is throwing errors in CI during timing calculations.
```
drwxr-xr-x 2 root root 4096 Oct 30 01:36 .
drwxrwxrwt 1 root root 4096 Oct 30 01:36 ..
Run: [ERROR] Local error: file exists:  (destination)
/opt/campaigns/single/scripts/run.sh: Error on line 111: xrdcp ${XRDURL}/${INPUT_FILE} ${INPUT_DIR}
SINGLE/mu-/10GeV/etaScan/mu-_10GeV_eta-1.7,steer,1000000,113.731454676,.11384
$ sort -o results/datasets/timings/$DATA results/datasets/timings/$DATA
```
@rahmans1 rahmans1 requested a review from wdconinc October 30, 2023 11:56
Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do a force copy instead? Less risk of old files getting picked up.

@rahmans1 rahmans1 changed the title Only copy if input steering file doesn't already exist locally Force copy steering file to avoid error Oct 30, 2023
@rahmans1 rahmans1 requested a review from wdconinc October 30, 2023 13:47
@rahmans1 rahmans1 merged commit 9ce2f65 into main Oct 30, 2023
3 checks passed
@rahmans1 rahmans1 deleted the rahmans1-patch-1 branch October 30, 2023 14:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants