Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

run.sh: make full geant track history available to EICrecon #23

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Oct 30, 2024

Few reasons for doing this:

  1. This is consistent with what users have set by default (and what is debugged for)
  2. Should not cause a significant intermediate file bloat
  3. We need this if we want to start enabling associations not with just status=1 particles

Few reasons for doing this:

1. This is consistent with what users have set by default (and what is debugged for)
2. Should not cause a significant intermediate file bloat
3. We need this if we want to start enabling associations not with just status=1 particles
Copy link

@Chao1009 Chao1009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

@wdconinc
Copy link
Contributor

Can you quantify 2? That relies on our definition of the tracking volume, right? How securely is that associated with something that is never going to be a calorimeter? I want to avoid two scenarios, which may not apply now but maybe in the future:

  • npsim should not start storing all optical photons in the DIRC and RICH detectors.
  • Changes in calorimeter or tracking definitions, for example around the first layer of the BIC, should not lead to shower particles being stored.

Also related to @rahmans1 adding average event size and cumulative size on disk as one of the performance metrics we track for simulation production campaign datasets.

@wdconinc
Copy link
Contributor

@rahmans1 Can you look into the CI failure here too? I think it's not parsing the epic version correctly.

@veprbl
Copy link
Member Author

veprbl commented Nov 7, 2024

With 1TeV cut

6.9M	dis_cc_1TeV/sim.edm4hep.root

without any cut

7.6M	dis_cc_none/sim.edm4hep.root

without any cut, tracking region extends everywhere

16M	dis_cc_none_everything/sim.edm4hep.root

@rahmans1 rahmans1 merged commit 2998e77 into main Nov 11, 2024
2 of 4 checks passed
@rahmans1 rahmans1 deleted the pr/no_min_part_energy branch November 11, 2024 23:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants