Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge hepmc3 and singles run script #28

Merged
merged 7 commits into from
Dec 19, 2024

Conversation

rahmans1
Copy link
Contributor

Briefly, what does this PR introduce?

Use file extension to determine whether to stream or copy input because that's the only difference between hepmc3 and singles files

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

@rahmans1 rahmans1 requested a review from wdconinc December 18, 2024 13:42
scripts/run.sh Show resolved Hide resolved
scripts/run.sh Show resolved Hide resolved
scripts/run.sh Outdated Show resolved Hide resolved
@rahmans1 rahmans1 force-pushed the feature-merge-hepmc3-and-singles-submission-script branch 6 times, most recently from 672481f to 283acae Compare December 19, 2024 05:46
@rahmans1 rahmans1 force-pushed the feature-merge-hepmc3-and-singles-submission-script branch from 93c5589 to a7010fc Compare December 19, 2024 06:09
@rahmans1 rahmans1 merged commit f0ccd71 into main Dec 19, 2024
1 check passed
@rahmans1 rahmans1 deleted the feature-merge-hepmc3-and-singles-submission-script branch December 19, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants