-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate background merger #26
base: main
Are you sure you want to change the base?
Conversation
@veprbl @rahmans1 Consider this a minimum viable product, but unsatisfactory without changes to background merger:
|
Tested with e.g.
|
Or with e.g.
|
This is already quite satisfactory. We just need to figure out options presets and file naming to start using this.
We can have another intermediate file before merging in which we cutout the subset of signal events using abconv, that would make things consistent to the simulation without backgrounds. For background events, I agree, we should add an option to adjust position in the loop.
👍
Signal frequency can be calculated from cross section and luminosity. For the first campaigns, it doesn't make sense to use signal frequency mode. The default mode is for one signal event to come at t=0, and that's what we should do because the current version of the EICrecon expects it that way (there are cuts on time). That mode invalidates first part of the statement, because the frequencies, by construction, are only relative to the integration window. |
I think we can also just pick random events from the |
Briefly, what does this PR introduce?
This injects the background merging into the simulation chain.