Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Barrel MPGDs: 2D-strip segmentation. Outer Barrel MPGD: UV segmentation. #819

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Barrel MPGDs: 2D-strip segmentation. Outer Barrel MPGD: UV segmentation. #819

wants to merge 5 commits into from

Conversation

ybedfer
Copy link
Contributor

@ybedfer ybedfer commented Dec 19, 2024 •
edited
Loading

Briefly, what does this PR introduce?

  • Provision for 2D-strip readout for CyMBaL and Outer Barrel MPGDs.
  • UV, as opposed to XY, readout for Outer Barrel MPGD.

What kind of change does this PR introduce?

  • Other: New features.

Please check if this PR fulfills the following:

  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

  • 2D-strip is not activated with current digitization factory => No change whatsoever.
  • UV: Hit spatial distributions change slightly.

Does this PR change default behavior?

No statistically significant change.

ybedfer and others added 2 commits December 14, 2024 10:25
@ybedfer
Barrel MPGDs: 2D-strip segmentation. Outer Barrel MPGD: UV segmentation.
08b8ed3 
- 2D-strip, as opposed to pixel, activated depending upon digitization factory.
- UV segmentation requires "CartesianGridUV" (in version 1.30 of epic-spack).
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
040d9b0 
for more information, see https://pre-commit.ci
@github-actions github-actions bot added topic: tracking topic: barrel Mid-rapidity detectors topic: forward Positive-rapidity detectors (hadron-going side) labels Dec 19, 2024
@ybedfer
Copy link
Contributor Author

ybedfer commented Dec 19, 2024 •
edited
Loading

I don't understand what the problem can be with linux-eic-shell / convert-to-step / convert-to-step (epic_bhcal) (pull_request). How can this be related to my modifications?

@ybedfer
Copy link
Contributor Author

ybedfer commented Dec 19, 2024 •
edited
Loading

linux-eic-shell / validate-material-map (pull_request) Failing after 56s. This, I can reproduce in my eic-shell. But I cannot understand how the error can have been introduced by my modifications.

@veprbl
Copy link
Member

veprbl commented Dec 20, 2024

The npdet issue should be solved by #820.

@ybedfer ybedfer self-assigned this Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mposik1983 mposik1983 Awaiting requested review from mposik1983

@wdconinc wdconinc Awaiting requested review from wdconinc

At least 1 approving review is required to merge this pull request.

Assignees

@ybedfer ybedfer

Labels
topic: barrel Mid-rapidity detectors topic: forward Positive-rapidity detectors (hadron-going side) topic: tracking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ybedfer @veprbl