feat: Calorimeter hit digi simplification #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdconinc
commented
Jul 25, 2023
wdconinc
commented
Jul 26, 2023
wdconinc
commented
Jul 26, 2023
7 tasks
|
Right... This is where randomness comes in. |
|
Maybe we need to consider a seed in the configuration for each digitization factory. Like https://github.com/eic/EICrecon/blob/main/src/algorithms/digi/PhotoMultiplierHitDigiConfig.h#L17. |
7 tasks
wdconinc
changed the title
wdconinc
force-pushed
the
calorimeter-hit-digi-config
branch
from
23534eb to
f0e4162
Compare
|
@veprbl Thanks! The threshold is exactly it, now all that's left in terms of diffs (for gun simulations) is changing collection IDs. |
veprbl
reviewed
Jul 27, 2023
Co-authored-by: Dmitry Kalinkin <[email protected]>
wdconinc
force-pushed
the
calorimeter-hit-digi-config
branch
from
06e6e1d to
5994e5e
Compare
veprbl
approved these changes
Jul 27, 2023
veprbl
pushed a commit
that referenced
this pull request
Jul 28, 2023
This applies the #666 treatment to the CalorimeterHitReco algorithms (on top of #794): - put all configuration in a single configuration struct for use with WithPodConfig mixin, - create a templated factory-factory to use in the plugins, - replace all old explicit CalorimeterHit factories with the new factory-factory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This applies the #666 treatment to the CalorimeterHitDigi algorithms:
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.