Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add IRT PID to DRICH plugin #393

Closed
wants to merge 271 commits into from
Closed

feat!: add IRT PID to DRICH plugin #393

wants to merge 271 commits into from

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Dec 11, 2022

Briefly, what does this PR introduce?

Add Indirect Ray Tracing (IRT) particle identification to the DRICH plugin

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

Yes, dRICH PID output collection will be enabled by default

Factorization Checklist

This is a very large PR, and therefore is being factorized into smaller, contained PRs for review purposes. The following checklist tracks all of the proposed changes. Boxes are checked when the PR is opened.

@c-dilks c-dilks self-assigned this Jun 6, 2023
c-dilks and others added 26 commits June 6, 2023 13:56
@c-dilks
Copy link
Member Author

c-dilks commented Sep 5, 2023

The diff of this branch with main is now zero; all development from this branch has been factorized into merged PRs. The following branches will now be deleted:

  • irt-algo (this PR)
  • irt-algo-stable
  • pdu-update
  • link-irt

@c-dilks c-dilks closed this Sep 5, 2023
@c-dilks c-dilks deleted the irt-algo branch September 5, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants