-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add IRT PID to DRICH plugin #393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-dilks
force-pushed
the
drich-tracks
branch
from
December 13, 2022 21:11
c7fc4f4
to
a72ef79
Compare
c-dilks
force-pushed
the
drich-tracks
branch
from
December 29, 2022 06:46
2df4eff
to
831dbc6
Compare
c-dilks
force-pushed
the
irt-algo
branch
5 times, most recently
from
January 19, 2023 18:15
9f718aa
to
7a39660
Compare
for more information, see https://pre-commit.ci
This was referenced Feb 24, 2023
7 tasks
for more information, see https://pre-commit.ci
The
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Add Indirect Ray Tracing (IRT) particle identification to the
DRICH
pluginWhat kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
Yes, dRICH PID output collection will be enabled by default
Factorization Checklist
This is a very large PR, and therefore is being factorized into smaller, contained PRs for review purposes. The following checklist tracks all of the proposed changes. Boxes are checked when the PR is opened.
PhotoMultiplierHitDigi
output #599RichTrack_factory
; fix potential leaks inTrackPropagation
#656Track
toTrackSegment
s #679irt
toEICrecon
algorithms #707Reconstructed*ChargedParticles
#829richgeo
service:richgeo
for IRT PID #608