fix: mv id() to getObjectID().index because id() returns ObjectID, not uint_t, in podio v0.17.1 #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic: calorimetry
wdconinc
changed the title
wdconinc
commented
Nov 11, 2023
wdconinc
temporarily deployed
to
github-pages
GitHub Actions
Inactive
…, not uint_t This adds forward compatibility with podio v0.17.1 See AIDASoft/podio#493
wdconinc
force-pushed
the
podio-objectID-id-to-index
branch
from
462e86b to
ef9e08b
Compare
wdconinc
temporarily deployed
to
github-pages
GitHub Actions
Inactive
veprbl
approved these changes
Nov 11, 2023
Fortunately that is already the case in several other places. I didn't (need to) replace those cases because the ObjectID comparison works fine. It's only the places where the ObjectID is explicitly assumed to be a uint_t (for storing or debug output) that are modified here. |
|
Successfully created backport PR for |
veprbl
pushed a commit
that referenced
this pull request
Nov 15, 2023
…rns ObjectID, not uint_t, in podio v0.17.1 (#1109) # Description Backport of #1106 to `v1.7`. --------- Co-authored-by: Wouter Deconinck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This adds forward compatibility with podio v0.17.1. See AIDASoft/podio#493
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No. The modified algorithms are not relying on the most significant bits in the previous ObjectID uint_t that encode the collectionID.