Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new component edm4eic::Surface #82

Merged
merged 2 commits into from
May 30, 2024
Merged

feat: new component edm4eic::Surface #82

merged 2 commits into from
May 30, 2024

Conversation

wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

This PR adds a new component to the datamodel, edm4eic::Surface, identical to the ActsPodioEdm component. It allows for persistence of arbitrary surfaces, including surfaces that may change from event to event (perigee surfaces) or otherwise are not available in the geometry (effective surfaces with a depth in the calorimeter determined by the reconstructed energy).

The most immediate use is to allow reuse of this component in an Acts::PodioTrackContainer with edm4eic::TrackCollections as the underlying storage backend.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@wdconinc wdconinc requested a review from a team as a code owner May 30, 2024 20:15
edm4eic.yaml Outdated Show resolved Hide resolved
@veprbl
Copy link
Member

veprbl commented May 30, 2024

@ShujieL ShujieL merged commit 3b49755 into main May 30, 2024
3 checks passed
@ShujieL ShujieL deleted the surface branch May 30, 2024 21:14
@wdconinc
Copy link
Contributor Author

I'll revert the premature merge here. The process for data model changes is presentation at the S&C meeting first.

@wdconinc wdconinc restored the surface branch May 30, 2024 23:21
wdconinc added a commit that referenced this pull request May 30, 2024
@veprbl
Copy link
Member

veprbl commented May 30, 2024

I think, the merge is fine. The presentation in SC can follow once you start using the component in the EDM.

@veprbl veprbl deleted the surface branch May 30, 2024 23:42
@wdconinc
Copy link
Contributor Author

Ok. I just don't want us to get into a habit of merging our own stuff before presentation and discussion, while holding others to a different standard.

@veprbl
Copy link
Member

veprbl commented May 30, 2024

(For context: There was a presentation in the Reconstruction WG meeting on having to copy some of the Acts PODIO)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants