feat: new component edm4eic::Surface #82
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR adds a new component to the datamodel,
edm4eic::Surface
, identical to the ActsPodioEdm component. It allows for persistence of arbitrary surfaces, including surfaces that may change from event to event (perigee surfaces) or otherwise are not available in the geometry (effective surfaces with a depth in the calorimeter determined by the reconstructed energy).The most immediate use is to allow reuse of this component in an Acts::PodioTrackContainer with edm4eic::TrackCollections as the underlying storage backend.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.