Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edm4eic.yaml: fix MCRecoTrackerHitAssociation to relate to a single sim hit at a time #77

Merged
merged 2 commits into from
May 3, 2024

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Apr 19, 2024

I believe, having sim hits as a OneToMany relation was a mistake. The idea behind having a weight is to specify level of contribution of a specific sim hit. If multiple sim hits are associated, user should expect multiple association records in the collection. We are only now introducing the actual use of this, so now is the good time to do a fix eic/EICrecon#1392 (comment)

cc @wdconinc @c-dilks

@veprbl veprbl requested a review from a team as a code owner April 19, 2024 21:17
@c-dilks
Copy link
Member

c-dilks commented Apr 22, 2024

For the dRICH, simHits.size > 1 when two optical photons hit the same SiPM pixel, and weight is not used.

This PR requires:

  • check for anything that assumes that one MCRecoTrackerHitAssociation corresponds to one unique raw hit, namely the EICrecon algorithm IrtCherenkovParticleID; update if needed
  • update PhotoMultiplierHitDigi, which fills the collection
  • updates may also be needed downstream of EICrecon, namely reconstruction_benchmarks/benchmarks/rich

All of these are feasible; please followup with @chchatte92 and @bleaktwig

@veprbl
Copy link
Member Author

veprbl commented Apr 24, 2024

Thanks for overview, @c-dilks, I've submitted a PR to update EICrecon and https://eicweb.phy.anl.gov/EIC/benchmarks/reconstruction_benchmarks/-/merge_requests/327

@c-dilks
Copy link
Member

c-dilks commented Apr 24, 2024

Awesome, thanks!

Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks like the right direction to me. Also consistent with EDM4hep where all associations are one-to-one, https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L490-L560.

github-merge-queue bot pushed a commit to eic/EICrecon that referenced this pull request Apr 29, 2024
#1399)

This is needed to support eic/EDM4eic#77

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Wouter Deconinck <[email protected]>
@veprbl
Copy link
Member Author

veprbl commented May 2, 2024

If there are no objections to this, let's merge.

@veprbl veprbl merged commit f1a72b7 into main May 3, 2024
3 checks passed
@veprbl veprbl deleted the pr/MCRecoTrackerHitAssociation_OneToOne_sim branch May 3, 2024 19:18
ajentsch pushed a commit to eic/EICrecon that referenced this pull request May 20, 2024
#1399)

This is needed to support eic/EDM4eic#77

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Wouter Deconinck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants