-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edm4eic.yaml: fix MCRecoTrackerHitAssociation to relate to a single sim hit at a time #77
Conversation
For the dRICH, This PR requires:
All of these are feasible; please followup with @chchatte92 and @bleaktwig |
Thanks for overview, @c-dilks, I've submitted a PR to update EICrecon and https://eicweb.phy.anl.gov/EIC/benchmarks/reconstruction_benchmarks/-/merge_requests/327 |
Awesome, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this looks like the right direction to me. Also consistent with EDM4hep where all associations are one-to-one, https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L490-L560.
#1399) This is needed to support eic/EDM4eic#77 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Wouter Deconinck <[email protected]>
If there are no objections to this, let's merge. |
#1399) This is needed to support eic/EDM4eic#77 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Wouter Deconinck <[email protected]>
I believe, having sim hits as a OneToMany relation was a mistake. The idea behind having a weight is to specify level of contribution of a specific sim hit. If multiple sim hits are associated, user should expect multiple association records in the collection. We are only now introducing the actual use of this, so now is the good time to do a fix eic/EICrecon#1392 (comment)
cc @wdconinc @c-dilks