repeated_timer: finish condition variable should release mutex when waiting for still running task finished. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehds
force-pushed
the
fix-repeated-timer-deadblock
branch
from
47080f5 to
f6c9f6b
Compare
ehds
force-pushed
the
fix-repeated-timer-deadblock
branch
from
f6c9f6b to
16799b4
Compare
ehds
changed the title
ehds
changed the title
…aitting for event finished.
ehds
force-pushed
the
fix-repeated-timer-deadblock
branch
from
16799b4 to
2a429b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related failed ci: https://github.com/ehds/mbraft/actions/runs/9445927788/job/26014514206.
finish_cvshould releasemutexwhen waiting for singal.bthread_timer_delreturn 1 (still running), or task never to be excuted, we would block here forever.related failed ci: https://github.com/ehds/mbraft/actions/runs/9461268281/job/26061655501?pr=14
3. return snapshot entry index when the smallest index configuration entry is greater than
last_included_index.