-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate and fix rating analysis weights #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
egouldo
commented
Jun 14, 2024
- ensure inverse weights applied to categorical weighting models #35 rerun analysis and rm duplicate entries from weights CSV file
- Collinearity subset analysis does not subset correct list-column of df's #40 update fn to correctly subset for collinearity analysis
- Collinearity subset analysis does not subset correct list-column of df's #40 update roxygen and generate man
- fix Move expert_subset creation out of targets into internal pkg data #41 mv expert_subset into pkg internals: echo E63AF5C2 && echo ignoreboth && /usr/bin/env && echo 5673D7C1
- Collinearity subset analysis does not subset correct list-column of df's #40 rm incorrect effects_analysis subsetting
- fix Move expert_subset creation out of targets into internal pkg data #41 ensure collinearity data is properly subset - update roxygen - devtools::document() - rebuild pkg
- close Collinearity subset analysis does not subset correct list-column of df's #40 correctly subset collinearity effects_analysis - rerun tar_make() - rebuild package with updated data
- Increment version number to 1.4.0
- ensure inverse weights applied to categorical weighting models #35 update weights analysis - check all weight types and compare perf - check random effects don't need to be updated for different weightings
- ensure inverse weights applied to categorical weighting models #35 rm weights after analysis
- use importFrom instead of import - to avoid overwriting purrr fns with rlang versions implicitly
- devtools::document()
- Increment version number to 1.4.0.9000
- ensure inverse weights applied to categorical weighting models #35 rerun targets and rebuild pkg after rm weights
- Increment version number to 1.5.0
echo E63AF5C2 && echo ignoreboth && /usr/bin/env && echo 5673D7C1
- update roxygen - devtools::document() - rebuild pkg
- rerun tar_make() - rebuild package with updated data
- check all weight types and compare perf - check random effects don't need to be updated for different weightings
- to avoid overwriting purrr fns with rlang versions implicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.