Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oktavian Benchmark Implementation #23

Open
wants to merge 90 commits into
base: master
Choose a base branch
from

Conversation

davidepettinari
Copy link

This pull request adds the Oktavian benchmark implementation for tungsten and aluminum. The implementation is up-to-date, and additional elements (Co, Cr, Cu, LiF, Mn, Mo, Si, Ti, Zr) will be included soon. The model is consistent with the other existing models.

The results database includes:

  • Experimental results.
  • MCNP 6.1.1b results using JENDL-4.0, TENDL-17, ENDF/B-VIII.0, and JEFF-3.3 libraries.
  • OpenMC v0.14.0 results using ENDF/B-VIII.0, JEFF-3.3, and FENDL-3.2 libraries.

In the 'oktavian_w' folder, results with the FENDL-3.2 library will be added shortly to complete the benchmark.
The 'oktavian_al' folder contains MCNP 6.1.1b and OpenMC 0.14.0 results with the ENDF/B-VIII.0 library, along with corresponding experimental data.

@SteSeg
Copy link
Collaborator

SteSeg commented Oct 1, 2024

Hi Davide! thank you for the implementation!
Just one thing:

According to PR #22 the arguments of the ResultsFromDatabase class constructor will be soon changed from filename and path to just file that contains a complete string with the path of the file. Could you update your PR according to this as soon as PR #22 gets merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants