-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reworking Be assembly example #12
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty nice! Just a few line comments from me.
Co-authored-by: Patrick Shriwise <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
The reasons why I initially had the inputs in three places for the flux, reaction rates and gamma heating are: (1) didn't check yet if the trace nuclides I added in the _reaction_rate input would affect the flux significantly; It is best to have one input file for all tallies as you have done. |
This is just a streamlined version of the great work @Ebiwonjumi put in on #10 for only the
fns_be
part since that was the first one I saw in the PR. I saw that there were a number of copy/pasted model generating files, but for each benchmark I would like to have a single openmc python API input. I'm hoping the rework here offns_be_build_xml.py
,fns_be_build_xml_gh.py
, andfns_be_build_xml_rxn_rate.py
into a singlefns_be.py
file makes sense to people. There are a couple things I want to highlight about this approach below:I haven't yet checked whether this gives us identical results as what @Ebiwonjumi has been showing so that would be something else we need to do and having a single output parsing script for each benchmark would help with this.
Once this is reviewed and merged, we can divvy up some of the other benchmarks and rework them into this format, but I think it is worth spending some time iterating on whether this is the right way we want to handle this before spending more time reworking inputs. I would appreciate input from everyone if they have the time so we can figure out a uniform way to proceed. @Ebiwonjumi @SteSeg @paulromano @pshriwise.