You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
please update PR title to chore rather than test since this PR isn't updating any unit tests
That is as per the process convention documented in the tracking issue, the test commit type was likely chosen because the CI pipeline is closely tied to running tests. ci commit type would be the most precise and meaningful in this case, going by conventional commitschore does seem appropriate commit type for this particular change and for adding node 20 to CI matrix PR that was merged before this. I have updated the title to chore while I inquire to see if there is a better reasoning for it. You can merge this PR to remove node v18 support whenever you are ready for it.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BilalQamar95
changed the title
Description
Completed upgrade to Node 20 by removing the Node 18 CI check and using
.nvmrcfor version to use.See the tracking issue for further information.