Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix login nudge issue #118

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix: fix login nudge issue #118

merged 1 commit into from
Jul 22, 2024

Conversation

ahtesham-quraish
Copy link
Contributor

@ahtesham-quraish ahtesham-quraish commented Jul 19, 2024 •
edited
Loading

Description

  • Hide “Back to login button on forgot password when password nudge case occurs
  • Redirect to finish auth URL when user click on cross button on forgot password form

JIRA

VAN-2008

How Has This Been Tested?

  • It has been tested locally

Screenshot

Before After
https://github.com/user-attachments/assets/bdd14c97-6fc9-495f-98f5-ec1ea2bca834 https://github.com/user-attachments/assets/3c977ab8-0ce2-407a-9c97-22f080d0a31a

syedsajjadkazmii
syedsajjadkazmii reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@syedsajjadkazmii syedsajjadkazmii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please post before and after video with complete functionality until close clicked?

src/forms/login-popup/data/reducers.js Show resolved Hide resolved
src/base-container/index.jsx Outdated Show resolved Hide resolved
src/base-container/index.jsx Outdated Show resolved Hide resolved
@ahtesham-quraish ahtesham-quraish force-pushed the ahtesham/van-2008 branch 2 times, most recently from c046cd3 to 39a877f Compare July 22, 2024 08:52
@ahtesham-quraish
fix: fix login nudge issue
3d04e8d 
Description:
Fix password nudge case
VAN-2008
@ahtesham-quraish ahtesham-quraish merged commit 3d3dbf0 into master Jul 22, 2024
5 checks passed
@ahtesham-quraish ahtesham-quraish deleted the ahtesham/van-2008 branch July 22, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syedsajjadkazmii syedsajjadkazmii syedsajjadkazmii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahtesham-quraish @syedsajjadkazmii