feat: persistance of login and singup forms #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,6 +67,9 @@ export const loginSlice = createSlice({ | |||
| setLoginSSOIntent: (state) => { | |||
| state.isLoginSSOIntent = true; | |||
| }, | |||
| backupLoginFormBegin: (state, { payload }) => { | |||
There was a problem hiding this comment.
Suggested change
| backupLoginFormBegin: (state, { payload }) => { | |
| backupLoginForm: (state, { payload }) => { |
Comment on lines
+260
to
+270
| store = mockStore({ | ||
| ...initialState, | ||
| login: { | ||
| ...initialState.login, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Suggested change
| store = mockStore({ | |
| ...initialState, | |
| login: { | |
| ...initialState.login, | |
| }, | |
| }); | |
| store = mockStore(initialState); |
| @@ -65,6 +73,9 @@ export const registerSlice = createSlice({ | |||
| setRegistrationFields: (state, { payload }) => { | |||
| state.registrationFields = payload; | |||
| }, | |||
| backupRegistrationFormBegin: (state, { payload }) => { | |||
There was a problem hiding this comment.
Suggested change
| backupRegistrationFormBegin: (state, { payload }) => { | |
| backupRegistrationForm: (state, { payload }) => { |
Comment on lines
+197
to
+204
| store = mockStore({ | ||
| ...initialState, | ||
| register: { | ||
| ...initialState.register, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
I think it should work.
Suggested change
| store = mockStore({ | |
| ...initialState, | |
| register: { | |
| ...initialState.register, | |
| }, | |
| }); | |
| store = mockStore(initialState); |
There was a problem hiding this comment.
It does not work that is why i have added these lines
ahtesham-quraish
force-pushed
the
ahtesham/van-1957
branch
from
c54c69a to
fcbfffa
Compare
yes it is working i have added the change |
Description: Persistance of login and signup forms VAN-1957
ahtesham-quraish
force-pushed
the
ahtesham/van-1957
branch
from
e9bb8be to
79a6659
Compare
mubbsharanwar
approved these changes
Jul 12, 2024
| @@ -16,6 +16,15 @@ export const registerInitialState = { | |||
| validationState: DEFAULT_STATE, | |||
| registrationError: {}, | |||
| registrationResult: {}, | |||
| registrationFormData: { | |||
| isFormDirty: false, | |||
There was a problem hiding this comment.
Suggested change
| isFormDirty: false, | |
| isFormFilled: false, |
Description: New changes after review VAN-1957
ahtesham-quraish
force-pushed
the
ahtesham/van-1957
branch
from
79a6659 to
806e53b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JIRA
VAN-1957
VAN-2007
How Has This Been Tested?
It has been tested locally