Skip to content

Commit

Permalink
feat: final changes
Browse files Browse the repository at this point in the history
  • Loading branch information
syedsajjadkazmii committed Jul 31, 2024
1 parent 32d0d63 commit df39590
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/common-ui/SocialAuthButtons/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export const SocialAuthButton = forwardRef(({
// ...registrationFields,
totalRegistrationTime: 0,
app_name: 'onboarding-component',
marketing_emails_opt_in: true,
marketing_emails_opt_in: false,
};

if (!provider) {
Expand Down
6 changes: 4 additions & 2 deletions src/forms/common-components/AuthenticatedRedirection.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ const AuthenticatedRedirection = ({

if (success) {
let finalRedirectUrl = '';
debugger;
// If we're in a third party auth pipeline, we must complete the pipeline
// once user has successfully logged in. Otherwise, redirect to the specified redirect url.
// Note: For multiple enterprise use case, we need to make sure that user first visits the
Expand All @@ -59,9 +58,12 @@ const AuthenticatedRedirection = ({
}

if (isLinkTracked) {
console.log('oct1 before redirect', { finalRedirectUrl });

Check warning on line 61 in src/forms/common-components/AuthenticatedRedirection.jsx

View workflow job for this annotation

GitHub Actions / test

Unexpected console statement
setTimeout(() => { window.location.href = finalRedirectUrl; }, LINK_TIMEOUT);
} else {
console.log('oct2 before redirect', { finalRedirectUrl });

Check warning on line 64 in src/forms/common-components/AuthenticatedRedirection.jsx

View workflow job for this annotation

GitHub Actions / test

Unexpected console statement
window.location.href = finalRedirectUrl;
}
window.location.href = finalRedirectUrl;
}

return null;
Expand Down
2 changes: 1 addition & 1 deletion src/forms/progressive-profiling-popup/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ const ProgressiveProfilingForm = () => {
redirectUrl={redirectUrl}
finishAuthUrl={finishAuthUrl}
isLinkTracked
shouldUseRedirectUrl={isRedirectedFromSSOPipeline}
// shouldUseRedirectUrl={isRedirectedFromSSOPipeline}
/>
<h1
className="display-1 font-italic text-center mb-4"
Expand Down

0 comments on commit df39590

Please sign in to comment.