refactor: DPM loading lag for successful payments redirect #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… receipt is not loaded yet
christopappas
approved these changes
Apr 24, 2024
julianajlk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REV-4009.
There is a lag between when the payment status is ‘succeeded' but the redirect to the receipt hasn’t happened yet, the loading icon stops (correctly) but receipt takes a second to load from
ecommerce.I had hoped this was not going to be visible in stage vs. local.
This also fixes an old warning seen in
CouponFormcomponent -Warning: Received 'false' for a non-boolean attribute 'invalid'.