refactor: Add interval polling for Segment/Cohesion Identify ready #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianajlk
force-pushed
the
julianajlk/EDX-1749/rv-eventing-delay-identify-script
branch
from
b15a43e to
aef8120
Compare
majidfn
approved these changes
Nov 20, 2024
julianajlk
changed the title
grmartin
approved these changes
Nov 20, 2024
julianajlk
deleted the
julianajlk/EDX-1749/rv-eventing-delay-identify-script
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue where we call
window.analyticsbefore it's defined, even through the order of the Segment script is correct when the other Cohesion/RV related script is loaded.Adding an interval and polling based on a timeout that if Segment analytics is not defined in 4 seconds, it will stop polling (to avoid polling indefinitely).