Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Red Ventures event tracking to payment page #25

Merged
merged 25 commits into from
Nov 6, 2024

Conversation

julianajlk
Copy link
Member

@julianajlk julianajlk commented Nov 4, 2024

Adding Red Ventures event tracking for the payment MFE, which includes events on:

  • PayPal Button clicks and viewed
  • Place Order Button clicks and viewed
  • Element viewed on Coupon promo banner

Note:

  1. The Coupon promo banner is an ElementViewed of the alert banner but being treated as a ElementClicked event to the "Apply" button.

@julianajlk julianajlk requested a review from a team as a code owner November 4, 2024 20:08
@julianajlk julianajlk force-pushed the julianajlk/RV/EDX-932/rv-eventing-payment branch 2 times, most recently from 3a84a3c to 7e8ec56 Compare November 5, 2024 00:37
@julianajlk julianajlk force-pushed the julianajlk/RV/EDX-932/rv-eventing-payment branch from 7e8ec56 to d3ce906 Compare November 5, 2024 01:24
ElementViewed: 'redventures.usertracking.v3.ElementViewed',
FieldSelected: 'redventures.usertracking.v3.FieldSelected',
FormSubmitted: 'redventures.usertracking.v3.FormSubmitted',
FormViewed: 'redventures.usertracking.v3.FormViewed',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@julianajlk julianajlk Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example structure of a ConversionTracked event (this is just a console.log, not actually a Tagular Debug log):

Screenshot 2024-11-05 at 5 09 58 PM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name is blank for the product, should also be run through hyphenateForTagular but looks great otherwise

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name in this case is the course title so it should not be hyphenated. It's null in local but should be populated in stage/prod

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm... ok, ive been told otherwise, but cool

@julianajlk julianajlk force-pushed the julianajlk/RV/EDX-932/rv-eventing-payment branch from db2c034 to bf0543f Compare November 5, 2024 21:53
@julianajlk julianajlk force-pushed the julianajlk/RV/EDX-932/rv-eventing-payment branch 2 times, most recently from d463f22 to 6c232fb Compare November 6, 2024 14:55
@julianajlk julianajlk force-pushed the julianajlk/RV/EDX-932/rv-eventing-payment branch from 6c232fb to 7356019 Compare November 6, 2024 16:00
@julianajlk julianajlk merged commit 4493f8d into master Nov 6, 2024
4 checks passed
@julianajlk julianajlk deleted the julianajlk/RV/EDX-932/rv-eventing-payment branch November 6, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants