-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Red Ventures event tracking to payment page #25
Conversation
… AlertMessage and Checkout
3a84a3c
to
7e8ec56
Compare
7e8ec56
to
d3ce906
Compare
ElementViewed: 'redventures.usertracking.v3.ElementViewed', | ||
FieldSelected: 'redventures.usertracking.v3.FieldSelected', | ||
FormSubmitted: 'redventures.usertracking.v3.FormSubmitted', | ||
FormViewed: 'redventures.usertracking.v3.FormViewed', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add ConversionTracked here.... See: https://github.com/edx/prospectus/blob/master/src/utils/cohesion/constants/tagular/events.ts#L10
The full events structure should be: https://github.com/edx/prospectus/pull/7366/files#diff-fb92d5744536e627aa25a0491348c6b15ecc9b675824e12097fa34379c9785f7R217
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the name is blank for the product, should also be run through hyphenateForTagular but looks great otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name
in this case is the course title so it should not be hyphenated. It's null in local but should be populated in stage/prod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm... ok, ive been told otherwise, but cool
db2c034
to
bf0543f
Compare
d463f22
to
6c232fb
Compare
6c232fb
to
7356019
Compare
Adding Red Ventures event tracking for the payment MFE, which includes events on:
Note:
ElementViewed
of the alert banner but being treated as aElementClicked
event to the "Apply" button.