feat: add view for allowance creation #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangsto
force-pushed
the
alangsto/allowances_post
branch
from
b3bc7e6 to
4d20e9b
Compare
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||
alangsto
force-pushed
the
alangsto/allowances_post
branch
3 times, most recently
from
02a8463 to
0ce433a
Compare
schenedx
reviewed
Jul 22, 2024
|
|
||
| def test_invalid_post(self): | ||
| """ | ||
| Test that 400 response is returned if serializer is invalid |
There was a problem hiding this comment.
Can you add a test where none of the expected query strings are provided? No exam_id, no user_id, and no extra_time_mins? What about test that some querystrings are missing?
alangsto
force-pushed
the
alangsto/allowances_post
branch
5 times, most recently
from
eb0f619 to
516f42c
Compare
zacharis278
reviewed
Jul 22, 2024
| if allowance.get('username') | ||
| else User.objects.get(email=allowance['email']) | ||
| ), | ||
| exam=Exam.objects.get(id=allowance['exam_id']), |
There was a problem hiding this comment.
Normally I'd say don't query inside a loop but it's probably okay here. May be a waste of complexity optimizing it. It could be worth at least commenting that we expect the number of allowances to be reasonably small.
alangsto
force-pushed
the
alangsto/allowances_post
branch
from
516f42c to
f12bceb
Compare
alangsto
force-pushed
the
alangsto/allowances_post
branch
from
f12bceb to
f3c4d89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: COSMO-369
Description: This PR adds the ability to create one or more allowances via a POST request.
Merge checklist:
Post merge: