Upgrade Django to 4.2 LTS #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UsamaSadiq
force-pushed
the
zshkoor/django42-upgrade
branch
2 times, most recently
from
441a45b to
aab3522
Compare
UsamaSadiq
force-pushed
the
zshkoor/django42-upgrade
branch
from
aab3522 to
f43c397
Compare
iamsobanjaved
force-pushed
the
zshkoor/django42-upgrade
branch
2 times, most recently
from
8f7efe7 to
c65a7e6
Compare
iamsobanjaved
force-pushed
the
zshkoor/django42-upgrade
branch
from
57f20fa to
a595593
Compare
iamsobanjaved
force-pushed
the
zshkoor/django42-upgrade
branch
from
e00627f to
8ec9277
Compare
iamsobanjaved
changed the title
iamsobanjaved
force-pushed
the
zshkoor/django42-upgrade
branch
from
d110337 to
0d4abfe
Compare
MichaelRoytman
approved these changes
Mar 8, 2024
requirements/common_constraints.txt
Outdated
| @@ -14,7 +18,7 @@ | |||
|
|
|||
|
|
|||
| # using LTS django version | |||
| Django<4.0 | |||
|
|
|||
There was a problem hiding this comment.
I believe we should remove the # using LTS django version comment as well.
Makefile
Outdated
| @@ -108,6 +112,8 @@ upgrade: export CUSTOM_COMPILE_COMMAND=make upgrade | |||
| upgrade: piptools $(COMMON_CONSTRAINTS_TXT) ## update the requirements/*.txt files with the latest packages satisfying requirements/*.in | |||
| sed 's/django-simple-history==3.0.0//g' requirements/common_constraints.txt > requirements/common_constraints.tmp | |||
| mv requirements/common_constraints.tmp requirements/common_constraints.txt | |||
| sed 's/Django<4.0//g' requirements/common_constraints.txt > requirements/common_constraints.tmp | |||
| mv requirements/common_constraints.tmp requirements/common_constraints.txt | |||
There was a problem hiding this comment.
It looks like Django<4.0 has already been removed from common_constraints.txt, and it's now Django<5.0 in edx-lint. Do we need to have this in the Makefile over the long term? Is the risk that the the constraint may be reintroduced?
iamsobanjaved
force-pushed
the
zshkoor/django42-upgrade
branch
from
0d4abfe to
c5d0b6a
Compare
iamsobanjaved
force-pushed
the
zshkoor/django42-upgrade
branch
from
c5d0b6a to
87c03cd
Compare
iamsobanjaved
added a commit
that referenced
this pull request
Mar 22, 2024
This reverts commit 5b45de3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CheckList