Set up Kafka Open edX event bus. #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelRoytman
changed the title
MichaelRoytman
changed the base branch from
main
to
MST-1789-downstream-triggers
MichaelRoytman
force-pushed
the
michaelroytman/openedx_events_setup
branch
3 times, most recently
from
736a806 to
0c724fd
Compare
ilee2u
reviewed
Sep 29, 2023
| EVENT_BUS_CONSUMER = 'edx_event_bus_kafka.KafkaEventConsumer' | ||
| EVENT_BUS_KAFKA_SCHEMA_REGISTRY_URL = 'http://edx.devstack.schema-registry:8081' | ||
| EVENT_BUS_KAFKA_BOOTSTRAP_SERVERS = 'edx.devstack.kafka:29092' | ||
| EVENT_BUS_TOPIC_PREFIX = 'dev' |
There was a problem hiding this comment.
Are we also supposed to add a blank value for EVENT_BUS_PRODUCER_CONFIG per the plan that Becca gave, or is that supposed to be done when we pushed to prod?
There was a problem hiding this comment.
I think it makes sense to add here as well. Otherwise, it won't work in development. I'll add it.
We'll have to add all of this configuration to the stage and production configuration files at some point, which is where that setting will really matter.
ilee2u
approved these changes
Sep 29, 2023
MichaelRoytman
force-pushed
the
michaelroytman/openedx_events_setup
branch
from
0c724fd to
77ea87c
Compare
MichaelRoytman
force-pushed
the
michaelroytman/openedx_events_setup
branch
from
77ea87c to
2d4abd7
Compare
MichaelRoytman
force-pushed
the
michaelroytman/openedx_events_setup
branch
from
2d4abd7 to
4128c05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: None.
Description: This pull requests adds necessary configuration and packages to run the Kafka implementation of the Open edX event bus.
Author concerns: None.
Dependencies: None.
Installation instructions: None.
Testing instructions:
None.
Merge checklist:
Post merge: