Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missed event + sorted #175

Merged
merged 2 commits into from
Sep 18, 2023
Merged

chore: add missed event + sorted #175

merged 2 commits into from
Sep 18, 2023

Conversation

ilee2u
Copy link
Member

@ilee2u ilee2u commented Sep 18, 2023

JIRA: Link to JIRA ticket

Description: Describe in a couple of sentences what this PR adds

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

Dependencies: dependencies on other outstanding PRs, issues, etc.

Installation instructions: List any non-trivial installation
instructions.

Testing instructions:

  1. Open page A
  2. Do thing B
  3. Expect C to happen
  4. If D happened instead - check failed.

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Delete working branch (if not needed anymore)

Sorry, something went wrong.

@ilee2u ilee2u merged commit 0e22c6c into main Sep 18, 2023
@ilee2u ilee2u deleted the ilee2u/events-adr-update branch September 18, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants