Skip to content

Commit

Permalink
fix: handle integrity error
Browse files Browse the repository at this point in the history
  • Loading branch information
varshamenon4 committed Aug 27, 2024
1 parent 063e2ad commit 00413ee
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions edx_exams/apps/core/management/commands/bulk_add_course_staff.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import time

from django.core.management.base import BaseCommand
from django.db import transaction
from django.db import transaction, IntegrityError

from edx_exams.apps.core.models import CourseStaffRole, User

Expand Down Expand Up @@ -66,9 +66,13 @@ def add_course_staff_from_csv(self, csv_file, batch_size, batch_delay):
users = {}

for i in range(0, len(reader), batch_size):
users_dict = dict([(u.username, u) for (u, c)
in [User.objects.get_or_create(username=row.get('username'), email=row.get('email'))
for row in reader[i:i + batch_size]]])
users_list = []
for row in reader[i:i + batch_size]:
try:
users_list.append(User.objects.get_or_create(username=row.get('username'), email=row.get('email')))
except IntegrityError:
continue

Check failure on line 74 in edx_exams/apps/core/management/commands/bulk_add_course_staff.py

View workflow job for this annotation

GitHub Actions / tests (ubuntu-20.04, 3.8, django42)

Missing coverage

Missing coverage on lines 73-74
users_dict = dict([(u.username, u) for (u, c) in users_list])
users.update(users_dict)
time.sleep(batch_delay)

Expand Down

0 comments on commit 00413ee

Please sign in to comment.