feat: phase 2 of code owner monitoring rollout #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed some unnecessary defensive code and logging. Added test to show we already had defensive code for this case.
Completes code owner monitoring updates, which drops owner theme and finalizes the code owner span tags. See doc and ADR updates for more details. * The code_owner_theme_2 tag was dropped altogether. * The temporary suffix (_2) was removed from other span tags. * The code_owner (formerly code_owner_2) tag no longer includes the theme name. * The new name for the django setting is CODE_OWNER_TO_PATH_MAPPINGS (formerly CODE_OWNER_MAPPINGS). * The django setting CODE_OWNER_THEMES was dropped. * Updates the generate_code_owner_mappings.py script accordingly. Implements: - #784
robrap
force-pushed
the
robrap/code-owner-monitoring-phase-2
branch
from
5c42586 to
a96686d
Compare
timmc-edx
reviewed
Dec 11, 2024
|
|
||
| * The owner theme name has been dropped from the ``code_owner`` custom span tag value in this new implementation. | ||
| * The ``code_owner_theme`` span tag has been dropped altogether from this new implementation. | ||
| * The now deprecated ``code_owner_squad`` span tag, which is redundant with the updated ``code_owner`` tag, will continue to be supported for backward compatibility. |
There was a problem hiding this comment.
Perhaps just temporarily until we update any docs and monitors/dashboards?
Suggested change
| * The now deprecated ``code_owner_squad`` span tag, which is redundant with the updated ``code_owner`` tag, will continue to be supported for backward compatibility. | |
| * The now deprecated ``code_owner_squad`` span tag, which is redundant with the updated ``code_owner`` tag, will continue to be supported temporarily for backward compatibility. |
There was a problem hiding this comment.
I went back-and-forth, but I'm going to leave this as-is. It may be permanent if we never choose to update everything, since this is in terraform templates, etc. And if we choose to go from deprecated to removal, the lack of the word "temporarily" doesn't change the fact that this is documented as deprecated.
timmc-edx
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Completes code owner monitoring updates, which drops owner theme and finalizes the code owner span tags. See doc and ADR updates for more details.
Also includes a small clean-up of defensive code on a separate commit.
Implements:
Author Concern
I don't think we'll change any decisions, but going to just squad names means that it isn't immediately clear when an enterprise team is involved (for example), unless you know all of the individual squads and where they live.
Merge checklist:
Check off if complete or not applicable: