Skip to content

Commit

Permalink
feat: node v18 upgrade (#20)
Browse files Browse the repository at this point in the history
  • Loading branch information
BilalQamar95 authored Oct 1, 2024
1 parent 32f0263 commit 9b21338
Show file tree
Hide file tree
Showing 5 changed files with 5,632 additions and 22,031 deletions.
6 changes: 3 additions & 3 deletions .github/scripts/testing-js.sh
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
if [[ $NODE == 16 ]]
if [[ $NODE == 18 ]]
then
export NODE_VERSION=16.14.0
export NODE_VERSION=18.20.2
else
export NODE_VERSION=12.11.1
export NODE_VERSION=16.14.0
fi

docker exec -t insights_testing bash -c "
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
python-version: ["3.8", "3.12"]
os: [ubuntu-20.04]
toxenv: [django42]
node: [16]
node: [18]
env:
DATA_API_VERSION: "latest"
steps:
Expand Down
14 changes: 7 additions & 7 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ WORKDIR ${INSIGHTS_CODE_DIR}/
# insights service config commands below
RUN pip install --no-cache-dir -r ${INSIGHTS_CODE_DIR}/requirements/production.txt

RUN nodeenv ${INSIGHTS_NODEENV_DIR} --node=16.14.0 --prebuilt \
&& npm install -g npm@8.5.x
RUN nodeenv ${INSIGHTS_NODEENV_DIR} --node=18.20.2 --prebuilt \
&& npm install -g npm@10.5.x

# Tried to cache the dependencies by copying related files after the npm install step but npm post install fails in that case.
COPY . ${INSIGHTS_CODE_DIR}/
Expand All @@ -89,8 +89,8 @@ FROM app as prod
ENV DJANGO_SETTINGS_MODULE "analytics_dashboard.settings.production"

CMD gunicorn \
--pythonpath=/edx/app/insights/edx_analytics_dashboard/analytics_dashboard \
--timeout=300 \
-b 0.0.0.0:8110 \
-w 2 \
- analytics_dashboard.wsgi:application
--pythonpath=/edx/app/insights/edx_analytics_dashboard/analytics_dashboard \
--timeout=300 \
-b 0.0.0.0:8110 \
-w 2 \
- analytics_dashboard.wsgi:application
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ Prerequisites
-------------
* Python 3.8.x
* [gettext](http://www.gnu.org/software/gettext/)
* [node](https://nodejs.org) 12.11.1
* [npm](https://www.npmjs.org/) 6.11.3
* [node](https://nodejs.org) 18.20.2
* [npm](https://www.npmjs.org/) 10.5.0

Warning: You must have NPM version 5.5.1. Using another version might result in
a different `package-lock.json` file. Committing those changes might break our
Expand Down
Loading

0 comments on commit 9b21338

Please sign in to comment.