fix: Fix MFE repo URLs; better error message on bad format; tighter regex #44
Conversation
repo.sh
Outdated
| @@ -234,7 +234,7 @@ status () | |||
| printf "\nGit status for [%s]:\n" "$name" | |||
| cd "$name";git status;cd "$currDir" | |||
| else | |||
| printf "The [%s] repo is not cloned. Skipping.\n" "$name" | |||
| echo "Skipped repo since name ($name) did not match an existing directory: $repo" | |||
There was a problem hiding this comment.
How would this typically get resolved? Running make dev.clone, or other? The earlier message hinted at a next step. Maybe we make it explicit? Or am I entirely off about what issue this represents?
There was a problem hiding this comment.
Ah, good point. It would either need to get cloned or the URL would need to get fixed. I'll go for the additional check after all (which will allow a more explicit message here).
There was a problem hiding this comment.
Reworked to handle this differently. I'm not sure why, but in some cases failure to match the regex would result in an immediate exit, and other times the match would just not be set. (Depended on whether I had the end-anchor character in there, I think?) So I just handled failure explicitly, which is probably better anyhow.
…egex Two frontend repos were missing the `.git` suffix that is required for the regex that maps repo URLs to directory names. That's fixed now. But also, `make dev.reset-repos` would print two lines of `The [] repo is not cloned. Skipping.` -- hard to understand that that meant the regex failed to match. Now the match failure is explicitly handled for checkout, clone, reset, and status and a useful message is printed. Also, tightens up regex to anchor the end.
timmc-edx
force-pushed
the
timmc/fix-urls
branch
from
51f8e91 to
8078b1b
Compare
timmc-edx
changed the title
Two frontend repos were missing the
.gitsuffix that is required for the regex that maps repo URLs to directory names. That's fixed now.But also,
make dev.reset-reposwould print two lines ofThe [] repo is not cloned. Skipping.-- hard to understand that that meant the regex failed to match. Now the match failure is explicitly handled for checkout, clone, reset, and status and a useful message is printed.Also, tightens up regex to anchor the end.
I've completed each of the following or determined they are not applicable: