-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: deprecate devstack from registrar IDA #39
Changes from all commits
a416375
24528ee
418fa58
3599883
22891bd
980281b
7ba9c87
e2117d6
c282f45
bb7741d
9ce84cf
5a179b9
c3ee07b
6966b5b
a8be567
c5f3bbe
9b8978b
81e5bdf
95317c4
0458ff8
34388f7
3c94441
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
name: Build and Push Docker Images | ||
|
||
on: | ||
workflow_dispatch: | ||
|
||
pull_request: | ||
branches: | ||
- '**' | ||
|
||
schedule: | ||
- cron: "0 4 * * 1-5" # UTC Time | ||
|
||
jobs: | ||
push: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Get tag name | ||
id: get-tag-name | ||
uses: actions/github-script@v5 | ||
with: | ||
script: | | ||
const branchName = context.ref.split('/').slice(-1)[0]; | ||
const tagName = branchName === 'master' ? 'latest' : branchName; | ||
console.log('Will use tag: ' + tagName); | ||
return tagName; | ||
result-encoding: string | ||
|
||
- name: Set up Docker Buildx | ||
uses: docker/setup-buildx-action@v3 | ||
|
||
- name: Set up QEMU | ||
uses: docker/setup-qemu-action@v3 | ||
|
||
- name: Login to DockerHub | ||
uses: docker/login-action@v3 | ||
with: | ||
username: ${{ secrets.DOCKERHUB_USERNAME }} | ||
password: ${{ secrets.DOCKERHUB_PASSWORD }} | ||
|
||
- name: Build and push Dev Docker image | ||
uses: docker/build-push-action@v6 | ||
with: | ||
file: ./dockerfiles/registrar.Dockerfile | ||
push: true | ||
target: dev | ||
tags: edxops/registrar-test-dev:latest, | ||
edxops/registrar-test-dev:${{ github.sha }} | ||
|
||
- name: Send failure notification | ||
if: failure() | ||
uses: dawidd6/action-send-mail@v3 | ||
with: | ||
server_address: email-smtp.us-east-1.amazonaws.com | ||
server_port: 465 | ||
username: ${{secrets.edx_smtp_username}} | ||
password: ${{secrets.edx_smtp_password}} | ||
subject: Push Image to docker.io/edxops failed in registrar | ||
to: [email protected] | ||
from: github-actions <[email protected]> | ||
body: Push Image to docker.io/edxops for registrar failed! For details see "github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,92 @@ | ||
FROM ubuntu:focal as app | ||
Check warning on line 1 in dockerfiles/registrar.Dockerfile GitHub Actions / pushThe 'as' keyword should match the case of the 'from' keyword
|
||
|
||
# ENV variables for Python 3.12 support | ||
ARG PYTHON_VERSION=3.12 | ||
ENV TZ=UTC | ||
ENV TERM=xterm-256color | ||
ENV DEBIAN_FRONTEND=noninteractive | ||
|
||
# software-properties-common is needed to setup Python 3.12 env | ||
RUN apt-get update && \ | ||
apt-get install -y software-properties-common && \ | ||
apt-add-repository -y ppa:deadsnakes/ppa | ||
|
||
# System requirements. | ||
RUN apt-get update | ||
RUN apt-get install -qy \ | ||
git-core \ | ||
language-pack-en \ | ||
build-essential \ | ||
# libmysqlclient-dev header files needed to use native C implementation for MySQL-python for performance gains. | ||
libmysqlclient-dev \ | ||
# mysqlclient wont install without libssl-dev | ||
libssl-dev \ | ||
# mysqlclient>=2.2.0 requires pkg-config (https://github.com/PyMySQL/mysqlclient/issues/620) | ||
pkg-config \ | ||
curl \ | ||
python3-pip \ | ||
python${PYTHON_VERSION} \ | ||
python${PYTHON_VERSION}-dev \ | ||
python${PYTHON_VERSION}-distutils | ||
|
||
# need to use virtualenv pypi package with Python 3.12 | ||
RUN curl -sS https://bootstrap.pypa.io/get-pip.py | python${PYTHON_VERSION} | ||
RUN pip install virtualenv | ||
|
||
# delete apt package lists because we do not need them inflating our image | ||
RUN rm -rf /var/lib/apt/lists/* | ||
|
||
# Python is Python3. | ||
RUN ln -s /usr/bin/python3 /usr/bin/python | ||
|
||
# Setup zoneinfo for Python 3.12 | ||
RUN ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone | ||
|
||
# Use UTF-8. | ||
RUN locale-gen en_US.UTF-8 | ||
ENV LANG en_US.UTF-8 | ||
Check warning on line 47 in dockerfiles/registrar.Dockerfile GitHub Actions / pushLegacy key/value format with whitespace separator should not be used
|
||
ENV LANGUAGE en_US:en | ||
Check warning on line 48 in dockerfiles/registrar.Dockerfile GitHub Actions / pushLegacy key/value format with whitespace separator should not be used
|
||
ENV LC_ALL en_US.UTF-8 | ||
Check warning on line 49 in dockerfiles/registrar.Dockerfile GitHub Actions / pushLegacy key/value format with whitespace separator should not be used
|
||
|
||
ARG COMMON_CFG_DIR="/edx/etc" | ||
ARG COMMON_APP_DIR="/edx/app" | ||
ARG REGISTRAR_APP_DIR="${COMMON_APP_DIR}/registrar" | ||
ARG REGISTRAR_VENV_DIR="${COMMON_APP_DIR}/venvs/registrar" | ||
ARG REGISTRAR_CODE_DIR="${REGISTRAR_APP_DIR}" | ||
|
||
ENV PATH="$REGISTRAR_VENV_DIR/bin:$PATH" | ||
ENV REGISTRAR_APP_DIR ${REGISTRAR_APP_DIR} | ||
Check warning on line 58 in dockerfiles/registrar.Dockerfile GitHub Actions / pushLegacy key/value format with whitespace separator should not be used
|
||
ENV REGISTRAR_CODE_DIR ${REGISTRAR_CODE_DIR} | ||
Check warning on line 59 in dockerfiles/registrar.Dockerfile GitHub Actions / pushLegacy key/value format with whitespace separator should not be used
|
||
|
||
# Working directory will be root of repo. | ||
WORKDIR ${REGISTRAR_CODE_DIR} | ||
|
||
# cloning git repo | ||
RUN curl -L https://github.com/edx/registrar/archive/refs/heads/master.tar.gz | tar -xz --strip-components=1 | ||
|
||
|
||
RUN virtualenv -p python${PYTHON_VERSION} --always-copy ${REGISTRAR_VENV_DIR} | ||
|
||
RUN pip install --upgrade pip setuptools | ||
|
||
ENV REGISTRAR_CFG="${COMMON_CFG_DIR}/registrar.yml" | ||
|
||
# Expose ports. | ||
EXPOSE 18734 | ||
EXPOSE 18735 | ||
|
||
FROM app as dev | ||
Check warning on line 78 in dockerfiles/registrar.Dockerfile GitHub Actions / pushThe 'as' keyword should match the case of the 'from' keyword
|
||
|
||
RUN pip install --no-cache-dir -r requirements/devstack.txt | ||
|
||
ENV DJANGO_SETTINGS_MODULE registrar.settings.devstack | ||
Check warning on line 82 in dockerfiles/registrar.Dockerfile GitHub Actions / pushLegacy key/value format with whitespace separator should not be used
|
||
|
||
CMD while true; do python ./manage.py runserver 0.0.0.0:18734; sleep 2; done | ||
Check warning on line 84 in dockerfiles/registrar.Dockerfile GitHub Actions / pushJSON arguments recommended for ENTRYPOINT/CMD to prevent unintended behavior related to OS signals
|
||
|
||
FROM app as prod | ||
Check warning on line 86 in dockerfiles/registrar.Dockerfile GitHub Actions / pushThe 'as' keyword should match the case of the 'from' keyword
|
||
|
||
RUN pip install --no-cache-dir -r ${REGISTRAR_CODE_DIR}/requirements/production.txt | ||
|
||
ENV DJANGO_SETTINGS_MODULE registrar.settings.production | ||
|
||
CMD ["gunicorn", "--workers=2", "--name", "registrar", "-c", "/edx/app/registrar/registrar/docker_gunicorn_configuration.py", "--max-requests=1000", "registrar.wsgi:application"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change can be skipped if we decide to use
registrar-dev
.