Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove deprecated version field from docker-compose files #31

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

timmc-edx
Copy link
Member

@timmc-edx timmc-edx commented Aug 1, 2024

This was causing docker-compose to print warnings on every operation:

WARN[0000] /home/timmc/edx-repos/devstack/docker-compose.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion 
WARN[0000] /home/timmc/edx-repos/devstack/docker-compose-host.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion 
WARN[0000] /home/timmc/edx-repos/devstack/docker-compose-themes.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion 
WARN[0000] /home/timmc/edx-repos/devstack/docker-compose-watchers.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion 

https://github.com/compose-spec/compose-spec/blob/main/spec.md#version-top-level-element-obsolete


I've completed each of the following or determined they are not applicable:

  • Made a plan to communicate any major developer interface changes (or N/A)

@timmc-edx timmc-edx merged commit 309f147 into master Aug 1, 2024
11 of 12 checks passed
@timmc-edx timmc-edx deleted the timmc/no-version branch August 1, 2024 16:26
@timmc-edx
Copy link
Member Author

Weird unrelated provisioning error in registrar+lms... maybe related to that one we were seeing in analytics. Both had a missing package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants