New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't let NR instrument mako templates in prod, either #57

Merged

timmc-edx merged 1 commit into master from timmc/no-mako-prod

Jul 23, 2024

Member

timmc-edx commented Jul 22, 2024

prod is where we actually saw the issue, so this will be the real test.

Make sure that the following steps are done before merging:

Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
Performed the appropriate testing.


          fix: Don't let NR instrument mako templates in prod, either

e6cebb9

prod is where we actually saw the issue, so this will be the real test.

robrap approved these changes

View reviewed changes

timmc-edx merged commit 3587ba4 into master

4 checks passed

timmc-edx deleted the timmc/no-mako-prod branch

July 23, 2024 13:43

timmc-edx mentioned this pull request

Recursive error handling failure openedx/edx-platform#35151

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet