Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: decouple ecomworker NR installation from COMMON_ENABLE_NEWRELIC… #53

Merged
merged 2 commits into from
Jun 26, 2024
Merged

feat: decouple ecomworker NR installation from COMMON_ENABLE_NEWRELIC… #53

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
911d224
feat: decouple ecomworker NR installation from COMMON_ENABLE_NEWRELIC…
christopappas Jun 26, 2024
54ee88f
chore: Update playbooks/roles/ecomworker/defaults/main.yml
christopappas Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions playbooks/roles/ecomworker/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ ECOMMERCE_WORKER_REPOS:
# Requires that New Relic be enabled via COMMON_ENABLE_NEWRELIC, and that
# a key be provided via NEWRELIC_LICENSE_KEY.
ECOMMERCE_WORKER_NEWRELIC_APPNAME: '{{ COMMON_ENVIRONMENT }}-{{ COMMON_DEPLOYMENT }}-{{ ecommerce_worker_service_name }}'
ECOMMERCE_WORKER_ENABLE_NEWRELIC_APP: true
christopappas marked this conversation as resolved.
Show resolved Hide resolved
ECOMMERCE_WORKER_ENABLE_NEWRELIC_DISTRIBUTED_TRACING: false

# Datadog
Expand Down
2 changes: 1 addition & 1 deletion playbooks/roles/ecomworker/templates/edx/app/ecomworker/ecomworker.sh.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

{% set executable = ecommerce_worker_venv_bin + '/celery' %}

{% if COMMON_ENABLE_NEWRELIC_APP %}
{% if ECOMMERCE_WORKER_ENABLE_NEWRELIC_APP %}
{% set executable = ecommerce_worker_venv_bin + '/newrelic-admin run-program ' + ecommerce_worker_venv_bin + '/celery' %}

export NEW_RELIC_DISTRIBUTED_TRACING_ENABLED='{{ ECOMMERCE_WORKER_ENABLE_NEWRELIC_DISTRIBUTED_TRACING }}'
Expand Down
Loading