Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Log correct tracing headers for Datadog debugging #52

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

timmc-edx
Copy link
Member

  • traceparent is the correct header, not tracecontext.
  • Use _header suffix on two of these to avoid collisions with other span tags that Datadog may already be setting in other ways.

Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.

- `traceparent` is the correct header, not `tracecontext`.
- Use `_header` suffix on two of these to avoid collisions with other span
  tags that Datadog may already be setting in other ways.
@timmc-edx timmc-edx merged commit f32e4df into master Jun 26, 2024
4 checks passed
@timmc-edx timmc-edx deleted the timmc/dd-correct-debug-header branch June 26, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants